From: Florian Müllner Date: Fri, 8 Jul 2022 19:36:07 +0000 (+0200) Subject: endSessionDialog: Small cleanup X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~461^2^2~260 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=97b20792579ee4dee3a04e75f46d5cfff0970cf8;p=gnome-shell.git endSessionDialog: Small cleanup Array.prototype.push() returns the new number of elements, so no need to track the number separately. Part-of: --- diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js index b0f71f5cf..dddfd51f0 100644 --- a/js/ui/endSessionDialog.js +++ b/js/ui/endSessionDialog.js @@ -647,7 +647,6 @@ class EndSessionDialog extends ModalDialog.ModalDialog { _loadSessions() { this._loginManager.listSessions(result => { - let n = 0; for (let i = 0; i < result.length; i++) { let [id_, uid_, userName, seat_, sessionPath] = result[i]; let proxy = new LogindSession(Gio.DBus.system, 'org.freedesktop.login1', sessionPath); @@ -675,7 +674,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog { type: proxy.Type, remote: proxy.Remote, }; - this._sessions.push(session); + const nSessions = this._sessions.push(session); let userAvatar = new UserWidget.Avatar(session.user, { iconSize: _ITEM_ICON_SIZE }); userAvatar.update(); @@ -699,8 +698,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog { this._sessionSection.list.add_child(listItem); // limit the number of entries - n++; - if (n == MAX_USERS_IN_SESSION_DIALOG) + if (nSessions === MAX_USERS_IN_SESSION_DIALOG) break; }